NiagaraSystemSimulation EmitterExecutionStateAccessors.GetWriter is always invalid

Development Rendering
, ,
1

Hi Epic team,

While debugging NDI, I found in NiagaraSystemSimulation.cpp, GetWriter always invalid, due to it is always called after DestinationData is set to nullptr. This is an issue, why have an invalid writer constantly caused by null destination buffer? Or maybe it has some intentional design purpose? Thank you!!

2

Steps to Reproduce

3

Hi,

It does appear that this might be vestigial and not needed any longer.

The original intention seems to have been to feed the any modification to Emitter ExecutionState in C++ back into be usable by the VM.

However it does appear that this no longer functions and is unneeded.

I will investigate further to be sure and remove if so.

Thanks for the find.

Thanks,

Simon