Intel GPA Debug Marker Names

Development Rendering
, ,
1

Hello,

We’ve noticed that debug markers won’t show up correctly in Intel GPA (they show as ‘%s’). We’re not sure if this is an issue with the PIX API or GPA itself, however we’ve applied a local change to D3D12CommandContext.cpp:

#if USE_PIX if (FD3D12DynamicRHI::GetD3DRHI()->IsPixEventEnabled()) { PIXBeginEvent(GraphicsCommandList().Get(), PIX_COLOR(0xff, 0xff, 0xff), GetNameStr()); } #endif

The resolves the issue for us and seemingly gets rid of the unnecessary string interpolation that was occurring before.

Thanks,

Jared

2

Hi,

Thanks for bringing this up. I am still in the process of verifying this formatting issue. Could you please provide me with a concrete example of where you are seeing the breadcrumbs displaying the format string inside the Intel GPA?

3

Okay, thanks for sending those screenshots over. I am still verifying your proposed fix (finding a PC with an Intel GPU can be surprisingly difficult). Once I have an update for you, I will comment here.

4

Thanks for pinging the thread again. I wanted to update you now to say that I have created a Jira ticket that will track the effort to fix this formatting bug: https://issues.unrealengine.com/issue/UE-296156. Someone from the Rendering team will be looking into integrating this change as soon as they can. Since you already have the fix in place, I think you can keep it around until the change is merged upstream. Please let me know if you have any further questions.

5

Hi again. I also wanted to let you know that we have now reported this bug to Intel, since it turns out they are incorrectly treating the format string characters. With your proposed fix, you can crash if your input string contains a % symbol. Therefore, please remove the fix you have in place until Intel provides a proper fix. Please let me know if you have any questions around this.

6

Hi Tim,

I’ve attached screenshots showing the issue before and after the above change. Let me know if you need anything more specific.

Thanks,

Jared

7

I’ve had to add another reply, UDN seems to limit to me to a single attachment per reply :S

8

Replying just to prevent auto closure.