VR Expansion Plugin

[Fantasifall]

@;648023

I’ll need you to try and find what process you have causing if possible, spent a while trying to replicate and looking over that section of code but an object should never be able to make it past the initial grip call with KeepOriginalMovement still set to true.

Ran with multiple objects set to that in multiplayer and none made it to the assert.

Did you test with KeepOriginalMovement or ForceClientSide? Because I don’t use KeepOriginalMovement on any of the objects, only ForceClientSideMovement. Maybe I didn’t understand your response entirely, just making sure.

[mordentral]

@Fantasifall;648209

Did you test with KeepOriginalMovement or ForceClientSide? Because I don’t use KeepOriginalMovement on any of the objects, only ForceClientSideMovement. Maybe I didn’t understand your response entirely, just making sure.

All objects by default are ForceClientSideMovement, that is why I was confused about you running into KeepOriginalMovement being set to true. You are somehow either corrupting a struct or altering one without knowing it as even replicating an empty default struct it will be ForceClientSideMovement by default unless uninitialized (structs constructor never ran). Are you deleting objects a lot?

@Shanowzer;648189

https://j.gifs.com/k5jmPJ.gif

Made with your plugin!

Nice, keep going!

@Shanowzer;648190

Is there any event to call when an actor is forced out of the grip?

ie. Collides with wall / swung too fast

Colliding with a wall bColliding should be set to true but generally I didn’t consider it because the actor/component itself will trigger an OnHit event and I didn’t see a reason to duplicate engine functionality.

Moving so fast that the object is farther than normal from the hand with physics grips there isn’t currently anything to tell you that, for the auto drop I read the constraint length and if it is too large than drop the object, I could add a function to get value if it is useful to you.

Auto drop btw calls the OnDrop event like a normal drop.

[UE4Hobbyist]

Getting crash when trying the local grip, just letting you know

MachineId:C96834D044A593A10B3F38AE029137B0
EpicAccountId:1c3b94657fc34a4a87cec5acbf729012

Access violation - code c0000005 (first/second chance not available)

UE4Editor_VRExpansionPlugin!UGripMotionControllerComponent::NotifyDrop_Implementation() [g:\unreal projects\runforcover\runforcover\plugins\-vrexpansionplugin-c3213dd8ce1e\source\vrexpansionplugin\private\gripmotioncontrollercomponent.cpp:1366]
UE4Editor_VRExpansionPlugin!UGripMotionControllerComponent::DropGrip() [g:\unreal projects\runforcover\runforcover\plugins\-vrexpansionplugin-c3213dd8ce1e\source\vrexpansionplugin\private\gripmotioncontrollercomponent.cpp:1147]
UE4Editor_VRExpansionPlugin!UGripMotionControllerComponent::DropActor() [g:\unreal projects\runforcover\runforcover\plugins\-vrexpansionplugin-c3213dd8ce1e\source\vrexpansionplugin\private\gripmotioncontrollercomponent.cpp:900]
UE4Editor_VRExpansionPlugin!UGripMotionControllerComponent::DropObject() [g:\unreal projects\runforcover\runforcover\plugins\-vrexpansionplugin-c3213dd8ce1e\source\vrexpansionplugin\private\gripmotioncontrollercomponent.cpp:586]
UE4Editor_VRExpansionPlugin!UGripMotionControllerComponent::OnUnregister() [g:\unreal projects\runforcover\runforcover\plugins\-vrexpansionplugin-c3213dd8ce1e\source\vrexpansionplugin\private\gripmotioncontrollercomponent.cpp:94]
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_CoreUObject
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Core
UE4Editor_Core
UE4Editor_Core
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_Engine
UE4Editor_UnrealEd
UE4Editor_UnrealEd
UE4Editor
UE4Editor
UE4Editor
UE4Editor
UE4Editor
kernel32
ntdll

[mordentral]

@UE4Hobbyist;648517

Getting crash when trying the local grip, just letting you know

I’ll look into it, but could you please wrap that in code tags instead of quote so it doesn’t take the entire page?

[mordentral]

@;648532

I’ll look into it, but could you please wrap that in code tags instead of quote so it doesn’t take the entire page?

Fixed, accidentally moved deleting a locally gripped object ahead of using it prior to deletion >.<.

Plugin and template are updated with the fix, also fixed an oversight in the template where it wasn’t checking for the locally gripped object on drop.

[UE4Hobbyist]

Works great now!

[Fantasifall]

@;648317

All objects by default are ForceClientSideMovement, that is why I was confused about you running into KeepOriginalMovement being set to true. You are somehow either corrupting a struct or altering one without knowing it as even replicating an empty default struct it will be ForceClientSideMovement by default unless uninitialized (structs constructor never ran). Are you deleting objects a lot?

I am. Every time a player dies, I drop his weapons (so that he can’t shoot, it’s also a good indication that he died), and then I destroy them. We did some playtesting today and the assert was thrown randomly while we were just teleporting around. I am setting the members of the InterfaceProperties without an authority switch at begin play, could cause any issues?

[mordentral]

@Fantasifall;648675

I am. Every time a player dies, I drop his weapons (so that he can’t shoot, it’s also a good indication that he died), and then I destroy them. We did some playtesting today and the assert was thrown randomly while we were just teleporting around. I am setting the members of the InterfaceProperties without an authority switch at begin play, could cause any issues?

Yeah that could possibly be an issue if it is only being set on one side, if you are resetting it to KeepOriginalMovement somehow for instance after it has already been gripped.

Like I said, the struct itself auto sets to ForceClientSideMovement when its constructor is called, the only way for it to bypass that is you to be manually setting it or somehow passing in an empty struct entirely with uninitialized values.

[anonymous_user_601851e1]

Colliding with a wall bColliding should be set to true but generally I didn’t consider it because the actor/component itself will trigger an OnHit event and I didn’t see a reason to duplicate engine functionality.

Moving so fast that the object is farther than normal from the hand with physics grips there isn’t currently anything to tell you that, for the auto drop I read the constraint length and if it is too large than drop the object, I could add a function to get value if it is useful to you.

Auto drop btw calls the OnDrop event like a normal drop.

is AutoDrop part of the new commit you pushed out? I can’t find it in the one back a commit.

Currently whenever the player drops a key item (one that is spawned in with them, ie sword / gun / something) it attaches back to their hip.

The problem is that when my player is moving and runs into a wall / swings the weapon too fast it stops grabbing it but doesnt reset it to the hip/socket

[Fantasifall]

@;648684

Yeah that could possibly be an issue if it is only being set on one side, if you are resetting it to KeepOriginalMovement somehow for instance after it has already been gripped.

Like I said, the struct itself auto sets to ForceClientSideMovement when its constructor is called, the only way for it to bypass that is you to be manually setting it or somehow passing in an empty struct entirely with uninitialized values.

That’s exactly why I am NOT using an auth switch on begin play, to make sure it’s set on both server and client. I am only playtesting with two grippable actors, and they have the same logic… I never change members after the initial initialization that happens on begin play.

[solodev (VirtualLilies)]

Question: has the plugin been tested with grabbing destructible objects ?

[mordentral]

@Shanowzer;648765

is AutoDrop part of the new commit you pushed out? I can’t find it in the one back a commit.

Currently whenever the player drops a key item (one that is spawned in with them, ie sword / gun / something) it attaches back to their hip.

The problem is that when my player is moving and runs into a wall / swings the weapon too fast it stops grabbing it but doesnt reset it to the hip/socket

Well that would trigger “OnDrop” on the held actor if it uses the interface. What are you looking for? An “OnAutoDrop” event on the controller itself that passes the object to drop back in? At that point it would probably be better to turn auto drop off and run your own checks, auto drop is just there for convenience.

By the way, for swords I wouldn’t suggest using a physics grip, there isn’t really a way around there being a slight offset due to the controller and the object being on different threads and if you run swords as a non interactive grip then they will feel attached to the hand instead of floaty.

@Shin_ji;648871

Question: has the plugin been tested with grabbing destructible objects ?

Yeah I picked up some destructed objects before, you have to be able to trace them as they default to the async physics thread I believe.

[mordentral]

Pushed a new commit to the plugin and template

Added in auto deletion of physics handles for pending kill objects,
ensured that grips are removed on pending kill objects.

Still better to manually Drop() an object prior to deleting it.  is a failsafe.

[Elleclouds]

I am having the hardest time installing ? Are there any detailed instructions on how to install plugin into 4.14.1. I read the:

1. Clone Or Download Zip and extract repository to a folder named “VRExpansionPlugin” in your “ProjectName/Plugins” directory, create directory if it is missing.

2. Add the VRExpansionPlugin to your projects PublicDependencyModuleNames in the projects build.cs if you have c++ code included.

3. IF you do not have c++ code, use the Add New button in the editor and add a blank c++ class to your project.

I will offer pre-compiled binaries for all builds as well eventually when the plugin is stable enough for it, but until then installing it in the project instead of the engine is better.

But for some reason, I get lost at step 2. Please help

[anonymous_user_198b0eb4]

If you have C++ code added to your project then just follow step 1 and start your project. It will ask you do you want to build, click yes let it do its stuff and you’re done. If you don’t have C++ code added then delete the plugin , start your game then add C++. Then start over at step one.

[Elleclouds]

@Tír na nÓg Games;649236

If you have C++ code added to your project then just follow step 1 and start your project. It will ask you do you want to build, click yes let it do its stuff and you’re done. If you don’t have C++ code added then delete the plugin , start your game then add C++. Then start over at step one.

When I do step 1. I get an error that says “plugin missing or incompatible modules in VRExpansionPlugin - would you like to disable it? You will no longer be able to open any assets created using it.”

After clicking ok, another message saying

Plugin ‘VRExpansionPlugin’ failed to load because module ‘VRExpansionPlugi’ could not be found. Please ensure the plugin is properly installed, otherwise consider disable the plugin for project". Then the Unreal Engine does not open. Please advise on how to install for a block head like me.

[solodev (VirtualLilies)]

@;648933

Well that would trigger “OnDrop” on the held actor if it uses the interface. What are you looking for? An “OnAutoDrop” event on the controller itself that passes the object to drop back in? At that point it would probably be better to turn auto drop off and run your own checks, auto drop is just there for convenience.

By the way, for swords I wouldn’t suggest using a physics grip, there isn’t really a way around there being a slight offset due to the controller and the object being on different threads and if you run swords as a non interactive grip then they will feel attached to the hand instead of floaty.

Yeah I picked up some destructed objects before, you have to be able to trace them as they default to the async physics thread I believe.

I’m using your plugin but based on Proteus template hence was wondering if grabbing destructible needs to be set up in a different way than grabbing static meshes.

[Elleclouds]

How do you install ? Anyone please throw me a bone.

[mordentral]

@Shin_ji;649419

I’m using your plugin but based on Proteus template hence was wondering if grabbing destructible needs to be set up in a different way than grabbing static meshes.

Oh…Well it should work the same for that, but the Proteus template is so far behind on plugin updates that not much else is going to be the same for you.

@Elleclouds;649483

How do you install ? Anyone please throw me a bone.

It has to be compiled for your engine version after setting up the folder correctly. is the unfortunate downside to supporting multiple engine versions and being unable to fully host all of the binaries on my subversion system.

Launching the editor won’t compile a plugin, you’ll need to load up the .sln file that was generated with the empty c++ class and hit build at the top.

Compiling Game Projects

[Elleclouds]

looks like its working