UWorldPartitionEditorSettings does not trigger PropertyChangeEvents correctly

Development World Creation
, ,
1

There seems to be a simple bug in UWorldPartitionEditorSettings::TriggerPropertyChangeEvent. The function currently looks like this… it fails to use the ‘PropertyName’ parameter.

void UWorldPartitionEditorSettings::TriggerPropertyChangeEvent(FName PropertyName)
{
  FPropertyChangedEvent PCE(GetClass()->FindPropertyByName(GET_MEMBER_NAME_CHECKED(UWorldPartitionEditorSettings, CommandletClass)), EPropertyChangeType::ValueSet);
  PostEditChangeProperty(PCE);
}

Most likely it was intended to look like this:

void UWorldPartitionEditorSettings::TriggerPropertyChangeEvent(FName PropertyName)
{
  FPropertyChangedEvent PCE(GetClass()->FindPropertyByName(PropertyName), EPropertyChangeType::ValueSet);
  PostEditChangeProperty(PCE);
}

A small mistake and easy to fix :slight_smile:

2

Hello!

Thanks for the report. I submitted the fix as CL56384613.

Regards,

Martin