When using UGS to sync an archive from perforce (in PerforceArchive.DownloadAsync()), if there is a network error or some other issue that causes an exception during that process, the exception is swallowed and the function returns true, as if the download succeeded.
I’ve made a small PR that catches any exceptions, logs them out and then returns false to indicate that the download failed. PR is here: UGS archive download exception handling by TI-asilva · Pull Request #13742 · EpicGames/UnrealEngine (new code highlighted on the attached image)
Let me know if you are interested in the PR and if not, I’ll close it.
[Image Removed]
Hi,
Sorry for the delay and thanks for the PR. We received it and it’s being tracked in JIRA UE-316379 and assigned to the proper team to investigate. The team will eventually triage the JIRA and review your proposal. It is small, so it should be straight forward. It looks good to me, but I’m not the one doing the call. The JIRA is still in ‘Triage’ status. When the team reviews it, they should respond on the PR itself to tell you ‘Thanks you’ or ‘Sorry, but we declined your PR for {reasons}’… if they follow the protocol. I will also link the JIRA to this ticket, so they might be able to give you some feedback here if they address it quickly enough.
Regards,
Patrick