TArray FindByPredicate causing access violation

Development Programming & Scripting C++
, , , ,
1

Hey guys.

Maybe im tired and cant see whats causing this but the following is what code ive got.

I cannot work out why the FindByPredicate is causing an access violation.

bool ASMFactionBase::DoesObjectClassMeetResourceRequirements(TSubclassOf<UObject> ObjectClass)
{
	if (!ObjectClass)
	{
		return false;
	}

	if (FactionTechTree)
	{
		//Find the GraphNode that the ObjectClass exists on so that we can query what its resource requirements are.
		UTechTreeGraphNode* ObjectNode = *(FactionTechTree->AllNodes.FindByPredicate([&](UTechTreeGraphNode* InNode)
		{
			return InNode->NodeAssetObject->IsChildOf(ObjectClass);
		}));

		if (ObjectNode && ResourceManagerComponent)
		{
			TArray<ASMResourceTypeBase*> Resources = ResourceManagerComponent->GetResources();

			for (const TPair<TSubclassOf<ASMResourceTypeBase>, int32>& ResourceRequirement : ObjectNode->ResourceRequirements)
			{
				//Find out if the Resource exists in the ResourceManager, if it doesnt then we cant continue because we obviously dont have the required resource.
				ASMResourceTypeBase* ResourceFromResourceManager = *(Resources.FindByPredicate([&](ASMResourceTypeBase* InResource) // <--------------- Access Violation on this Line.
				{
					return InResource->IsA(ResourceRequirement.Key);
				}));

				//If we do have the required resource, then find out if we have enough of it.
				if (ResourceFromResourceManager)
				{
					if (ResourceRequirement.Value > ResourceFromResourceManager->ResourceAmount)
					{
						return false;
					}
				}
				else
				{
					return false;
				}
			}
		}
		else
		{
			return false;
		}
	}

	return true;
}

If there is someone that can point out a possible issue with this please do reply :slight_smile:

If you need more information let me know, i hope the comments are enough.

Thanks.

2

Just to clarify, it seems to be caused when there is an Element in ResourceRequirement that is not in Resources

I dont understand why this would be causing it to occur. I was under the impression that the Predicate should just return an nullptr.

3

Just to be sure, and exclude any potential crash from here:

instead of

{
             return InNode->NodeAssetObject->IsChildOf(ObjectClass);
}

make it

{
             if(!InNode || !InNode->NodeAssetObject) return false;
             return InNode->NodeAssetObject->IsChildOf(ObjectClass);
}

and tell us if it still crash

EDIT:
sorry, took the wrong predicate…

{
       return InResource->IsA(ResourceRequirement.Key);
}

to

{
       if(!InResource)return false;
       return InResource->IsA(ResourceRequirement.Key);
}

also, when it crash, could you lood at the values inside “Resources” to check if there is a null / invalide /garbage collected one ?

4

I tried that earlier and it didnt help which is really weird, thats what makes no sense.

5

Still having this issue. Anyone else can possibly explain it?

6

Ok, found the answer, you are dereferencing a null pointer (thx captain obvious )

explanation :

you said : “it seems to be caused when there is an Element in ResourceRequirement that is not in Resources”
and indeed, the find by predicate would return NULL in that case, but you still try to dereference the pointer ( of pointer ) in that case

Solution :

ASMResourceTypeBase* ResourceFromResourceManager =NULL;
auto result = Resources.FindByPredicate([&](ASMResourceTypeBase* InResource) 
                 {
                     return InResource->IsA(ResourceRequirement.Key);
                 });
if(result)
    ResourceFromResourceManager =*(result);
7

I had similar issue and this really helps me. :slight_smile: