What is the concept behind splitting the tags for “Swarm” vs “SwarmApproved”? I don’t understand how to use them. Previously, I had a “reviewed by” tag which had a button for “create review” if none existed. This tag would then auto-populate with the name of the reviewer when the review is approved.
Now, only the “Swarm” InputSubType gets a “create review” button, as “SwarmApproved” just gets a refresh button. And only “SwarmApproved” InputSubType will auto-populate with the name of the reviewer. Is the intent that I use both, or was the change to auto-populating the reviewer intended to be for both InputSubTypes?
they’re different in the sense that Swarm is for requesting reviews and it has logic to create new swarm reviews, and SwarmApproved is for people that have approved said review, it has logic to fetch the people that upvoted the review and automatically set them as the value. We use both internally, right now we don’t have a combined single tag that would handle both under the same field. It shouldn’t be hard to set up if you want it that way
We use the two of them because it was deemed as valuable to have the information about who were in the review on top of who approved the review, this helps us to identify additional stakeholders in case we needed to track them. Additionally, it also allows for different tag validation conditions, where we can require a SwarmApproved to be populated but leave the Swarm one alone as a utility that people can use or not since there are cases where a review has been done, but not through swarm for instance.
Internally we don’t want Swarm to auto-populate with approved reviewers since we use it the other way around and we want the information of all reviewer candidates, not just reviewers that approved. It could be confusing to have a user populate a tag with say name.one and name.two to request a review only for it to be erased automatically afterwards because no-one has approved it yet
It would seem that everyone who requests a review also wants to track who has upvoted the review since the point of the #rb tag is to show who reviewed the changelist. How do you use both tags currently since both Swarm and SwarmApproved require a # tag value to be added to your changelist? Do they share a common tag value? Isn’t it confusing to have two separate textboxes for tag values and two separate checkboxes, as if you could turn on SwarmApproved but not use Swarm? I am still confused how you make use of these.
In the meantime, I modified Swarm to auto-populate the reviewer like SwarmApproved, something I’m not sure why is not in your code.