Small feature request for UFastGeoWorldPartitionRuntimeCellTransformer for extensibility

Development World Creation
, ,
1

I see recent changes to the FastGeo plugin moved classes so we can subclass them and use them more easily, thank you for that. I have some additional small requests for adding extensibility.

  1. Can you make UFastGeoWorldPartitionRuntimeCellTransformer::Transform not be final? This can let us add our own filtering to a sub-class before calling Super::Transform(InLevel).
  2. Can you make all the TSubclassOf<> properties use meta=(AllowAbstract) for better class filtering?

Thank you

2

Steps to Reproduce

3

Hi Matt,

2- I agree, I will change this and let you know when it’s in (with CL).

1- The reason why it was initially set final was because there is a lot going on in that function and custom filtering should be possible by overriding these:

/** Whether the actor can be processed by the transformer. */
virtual bool IsActorTransformable(AActor* InActor, FString& OutReason) const { return true; }
/** Whether the component can be processed by the transformer. */
virtual bool IsComponentTransformable(UPrimitiveComponent* InComponent, FString& OutReason) const { return true; }
/** Whether the fully transformed actor can be deleted by the transformer. */
virtual bool IsFullyTransformedActorDeletable(AActor* InActor, FString& OutReason) const { return true; }

Let me know why these are not sufficient and I will be glad to add what’s missing.

Richard

4

I see, I will add

virtual bool IsLevelTransformable(ULevel* InLEvel, FString& OutReason) const { return true; }Also, I submitted the change to allow abstract classes in our main branch : CL 46001817.

Cheers

5

Hi Matt,

Submitted in our main branch : CL 46060680.

I’ve put the virtual in the base class so any transformer can override it.

Richard

6

My use case is to apply filtering on the ULevel. IsActorTransformable does work, but I have to iterate on every actor which is just extra work. The filtering I am doing is to only allow the transformer to run on certain grid names. This is the code I have if you wanted to add that directly instead, could also add an exclusion list as well.

	const auto StreamingCell = CastChecked<UWorldPartitionRuntimeLevelStreamingCell>(InActor->GetLevel()->GetWorldPartitionRuntimeCell());
	if (!StreamingCell->RuntimeCellData || (!GridsToApplyTransformer.IsEmpty() && !GridsToApplyTransformer.Contains(StreamingCell->RuntimeCellData->GridName)))
	{
		return false;
	}

I am fine with overriding IsActorTransformable for this if we need. Its not a huge deal.

Thank you for the help :slight_smile:

7

Works for me! Thank you so much for the quick turn around :slight_smile:

When you submit the IsLevelTransformable change let me know