RHI thread improvements for version 5.4 - patching error

Development Programming & Scripting
, ,
1

Could you please help me with the proper integration of the patch?

2

Steps to Reproduce
I would like to implement the patch you mentioned in this article:

[Content removed]

[Content removed] files you provided us there compile fine with 5.4 release from github.

However, you also mentioned the need to integrate CL31417988:

[Content removed]

I replaced files in my repository with CL31417988 content, also removed RHIResourceUpdates.h and RHIResourceUpdates.cpp

I’ve noticed that SkeletalMeshUpdate.cpp and SkeletalMeshUpdate.h are missing in the clean 5.4 source download, but are not marked as new files in CL31417988. Anyways, the engine is not compiling now.

[Image Removed]

It says

“GRH…” is an undeclared identification.

“IRHIC…” function does not takes 6 arguments

and so one.

Best,

Adam

3

Hi,

I followed the same steps (implementing the base patch and then cherry picking this commit) and could reproduce the same errors. I found that some changes from other commits are missing which is preventing the code from compiling. I will file a bug report for this with Epic.

Thanks,

Sam

4

Hi Adam,

It appears that you might have copied the files from CL31417988 on top of the 5.4 sources. This CL was submitted on Main around the 5.5 time and cannot be simply copied over. You must merge the changes for each file in the CL\commit.

We also suspect that your codebase might not have been properly changed when you updated from 5.3.x to 5.4.x. SkeletalMeshUpdate.cpp and SkeletalMeshUpdate.h have been around for a while now but they were relocated in version 5.4.

  • Before 5.4: Engine\Source\Runtime\Engine\Private\Streaming\
  • After 5.4 : Engine\Source\Runtime\Engine\Internal\Streaming\

Regards,

Martin

5

Hi,

Here is a link to the issue on the public issue tracker where you can follow its progress.

Thanks,

Sam