"New Take" option produces incorrect names

Development Character & Animation
, ,
1

When we use "new take " option on a level sequence with name “FX_SH004x00-01”, it produces the name “FX_SH000004-02” instead of “FX_SH004x00-02” as a suggested name for the new take. We’ve already configured our project settings to consider “-” as the take separator so there is no excuse to get it wrong

2

Steps to Reproduce
In Sequencer with a subsequence try to create a take using “New take” option

3

Hello [mention removed]​,

Thanks for the report. After reviewing the behavior I confirmed that the issue comes from how MovieSceneToolHelpers::ParseShotName interprets the sequence name when creating a new take.

The parser looks for the first numeric character in the name and assumes that every digit up to the take separator belongs to the shot number. In your example FX_SH004x00-01 the parser sees the first zero in 004x00 as the start of the shot number and treats the entire span 004x00 as one numeric block, even though it contains non numeric characters. As a result it reads a shot number value of 4 with six digits and a take number of 1 which leads to the incorrect suggestion FX_SH000004-02.

These are the values obtained by MovieSceneToolHelpers::ParseShotName.

[Image Removed]This behavior remains unchanged in recent builds from Main. There was a previous fix for a related issue where no shot number was present, but in this case the parser still detects a shot number because of the digits inside the prefix.

If you are working with a source build, a possible workaround is to adjust the ParseShotName logic so that if the detected shot number span contains non numeric characters, the code falls back to treating everything before the separator as the prefix. Please let me know if you work with a source build and I can share more details.

I will file a bug report for this so it can be tracked internally and will update you as soon as possible.

Best,

Francisco

4

Hey Francisco,

Thanks for a thorough and comprehensive explanation and filing a bug report!

I think it might be beneficial if the parser could work with different naming conventions.

We’re looking forward to the update, in the meantime we’ll figure out a workaround workflow

Best,

Marty

5

Hey Marty,

I JIRA has been submitted for this issue. I will let you know when I hear more.

Tony

6

Thanks Tony!