Issue in HordeHttpClient.cs – incorrect query parameter names

Development Pipeline & Plugins
, ,
1

Hello,

while investigating UGS, I came across an issue in the file HordeHttpClient.cs, specifically in the GetProjectsAsync method.

When using the includeStreams or includeCategories arguments, the generated HTTP request contains incorrect query parameter names (includeStreams and includeCategories) instead of Streams and Categories.

According to the implementation in the GetProjects method in ProjectsController.cs, the expected parameter names are Streams and Categories.

As a result, these parameters are not handled correctly by the server.

Best regards,

Lubos Suk

[Attachment Removed]

2

Steps to Reproduce[Attachment Removed]

3

Hi Luboš,

Thank you for the report. I just reviewed the code you mentioned and there does seem to be a parameter name mismatch.

Moreover, I think there is another mismatch in the GetDashbordPreviewsAsync() method from HordeHttpClient.cs. It calls endpoint “api/v1/dashboard/preview” (singular) with the “open” query parameter, but the implementation that takes this parameter is from GetDashbordPreviewsAsync() in DashboardController.cs, which handles route “/api/v1/dashboard/previews” (plural).

I’m filing an internal bug report for those, and I should get back to you soon with a tracking number for it. Meanwhile, please let me know if the expected fix makes it work correctly on your end.

Best regards,

Vitor

[Attachment Removed]

4

Hi Vitor,

thanks for confirmation.

And i can confirm, that fixing parameters in method i mentioned above solved my issues. I just wana to let you know about this mismatch.

thanks and regards

Lubos

[Attachment Removed]

5

Here’s the tracking number for the bug: UE-364682. This link should become available once the devs mark it as public.

All the best,

Vitor

[Attachment Removed]