Injecting custom Editor menus from C++

Were there big changes to how menu’s are injected into editor from C++? I’m just following quick example

and the menu and sections injection works, but menu option:
https://paste.gg/p/anonymous/cc0c984f3c464d448968621cab722b61
never appears. Seems like void MenuTool::OnStartupModule() which generates one is never called. The problem is it is all abstracted through UE nonsense so you cant tell where something is/should be called indirectly or directly with this.