Fix a bug where the selected path view filters list grows unbounded

Development Pipeline & Plugins
, ,
1

Hi! We discovered a bug where the user’s selected path view filters get appended to their path view config settings on every boot of the editor. This was causing the persisted list to grow unbounded with duplicates until the user clears their filters. It’s not terrible because only one duplicate gets added per editor session, but over a long period of time it could start to have a (small) boot time perf impact.

We fixed the issue and figured this could benefit others as well, so we’ve gone ahead and made a PR with this small patch - it would be great if it could be upstreamed!

https://github.com/EpicGames/UnrealEngine/pull/13781

Let me know if I can provide any additional clarification.

Thanks!

2

Steps to Reproduce

  1. Enable a filter from Content Browser -> Settings -> Path View Filters
  2. In the debugger, set a breakpoint in SPathView::SetPluginPathFilterActive
  3. Boot the editor several more times, and observe the PathViewConfig->PluginFilters collection
  4. Observe that the collection contains an additional duplicate for each boot of the editor
3

Hi Russell, we have received the github PR. Generally it is sufficient to submit on github and provide any additional info on repro steps as part of the PR itself.

I’ve added the steps to repro to our internal tracking.