Do/while loop is freezing the engine? Help!

Development Programming & Scripting C++
, , , ,
1

HI, the loop in my code is freezing the game, how to make it optimized or something that it will play smoothly.

What the loop does?
check for the Transform.locations if they are dupliacted randomize them by -1.

do
{
	Location = Available[FMath::RandRange(0, Available.Num() - 1)];
} while 
(ArrayLocations.ContainsByPredicate([Location] (const FTransform Transform)
{
	return Transform.GetLocation() == Location.GetLocation();
}));

SpawnLocation = Location;

ArrayLocations.Add(SpawnLocation);

the first time I run the engine using visual studio, click play and everything works fine , I stopped the game and run it again, the engine freez and I have to close it using visual studio stop button.

2

Can you print the size of the ArrayLocations just after this loop ends?

1 Like
3

the engine crashed with the
error C2148 - total size of array must not exceed 0x7fffffff bytes

4

clear the ArrayLocations before the second time you execute the loop, right in the end where you add spawnlocation to the array, you don’t need arraylocation to store the old data.

SpawnLocation = Location;
ArrayLocations.Add(SpawnLocation);
ArrayLocation.Empty(); // this can fix the crash and freez issue
2 Likes
5

Thank You Sir for helping me solve this issue the trouble of +5 days, really appreciated :slightly_smiling_face:

6

glad it helps you

7

Wat?
Whats the point of storing data in array when you immediately clears that array?

8

storing the data in the array just to grab the locations and then recheck if the locations are duplicated.

ArrayLocations is the reference of const Available

9

This is the full code,

for (auto SpawnArrayElements : ItemsIDArr)
{
	do
	{
		Location = Available[FMath::RandRange(0, Available.Num() - 1)];
	} while (ArrayLocations.ContainsByPredicate([Location](const FTransform Transform)
		{
			return Transform.GetLocation() == Location.GetLocation();
				//&& Transform.GetRotation() == Location.GetRotation()
				//&& Transform.GetScale3D() == Location.GetScale3D();
		}));
		SpawnLocation = Location;
		ArrayLocations.Add(SpawnLocation);
}
	ArrayLocations.Empty();

I am doing something wrong?

10

How many elements you have in ArrayLocations after that code?

11

it has 100 elements stored in the data table of vector locations

12

Are you sure? After ArrayLocations.Empty() call?

13

You are causing infinite loops

14

after that arrayLocation.Empty() call , the ArrayLocation is called somewhere to store the fresh instance of the locations available in the data table

15

how is it possible, the first time I launch the game this is not infinite loop, the second time I launch the game it freezez

16

image_2022-08-22_042150808
image_2022-08-22_0421508081272×705 79.9 KB

this is the result of the generated item function