CommonUI Input Handling Ignores All Editor Bindings

Development Pipeline & Plugins
, ,
1

CommonUIActionRouterBase seems to be manually handling one and only one commonly used editor binding and ignoring all other bindings which made tracking this issue sadly harder than it should have been I think. There seems to be some flow developed to allow processing editor bindings within CommonUIActionRouterBase, however it is being used to only process the `StopPlaySession` binding which seems to be confusing and unintuitive to our developers. Could this be updated to process all bindings normally being processed or maybe a list of them that’s controlled by another config to allow more functionality to be provided?

[Attachment Removed]

2

Steps to Reproduce

  • Enable CommonUI, EnhancedInput plugins & and enable CommonUI input system so when UI is active it is processed by `UCommonUIActionRouterBase`
  • While playing the game, press on an editor key binding, F11 for example to make the game full screen and observe it is working
  • Open a menu to pass the control to the ui action router system, press the same keybinding and observe it is being ignored
    [Attachment Removed]
3

Hi,

Good callout, it looks like we never followed up on the TODO there. We’re testing out a change to offload this to a config file so that other editor keybinds can be registered to pass through the router, if we’re able to get that change checked in then I’ll share a CL with you.

Best,

Cody

[Attachment Removed]

4

Thanks a lot Cody, I am looking forward to that change.

[Attachment Removed]

5

Hi,

Just wanted to send along a quick update, I refactored this a bit to add the passthrough list to the CommonUI editor settings and prepopulate it with the “exit PIE” keybind to keep existing functionality, that’s being reviewed now so I’ll update again with a CL soon.

[Attachment Removed]

6

Sorry for the delay, the final revision is checked in at CL#54899609. With that, you’ll see two new settings in Project Settings->Plugins->CommonUIEditor. The first, Passthrough Stop Play Session, is a checkbox (on by default) for the legacy functionality of explicitly allowing the Stop PIE hotkey to pass through the router. The second, Editor Passthrough Commands, will let you specify additional keybinds that you want the router to pass along.

[Attachment Removed]