We don’t want the editor to submit to perforce without the user going through Submit Tool.
Steps to Reproduce
When a collection is deleted, the editor will automatically submit the file that is locally marked for deletion. Similarly, it will automatically commit to perforce when a collection is saved, but you can prevent this using the UCollectionSettings::bAutoCommitOnSave boolean. We’ve gone ahead and made our own boolean: UCollectionSettings::bAutoCimmitOnDelete, and modified the code so that an auto-submit doesn’t happen, but I thought I would post here with a request that maybe Epic incorporate this change? Maybe you’ve already made the change, and we’ll get it in the next drop?
We try to maintain tight control over what is submitted. For example, we’re using Epic’s Submit Tool to enforce certain commit messages, etc.
Thank you for taking the time to look at this.
Hi,
We haven’t made any changes here since the updates to support bAutoCommitOnSave, though I worry supporting collection deletion without a checkin would require deeper changes than supporting collection updates. There’s some risk of ending up in a bad state, and things like rename would need to be supported properly as well. If you’ve made those changes locally and want to run them by the team, you can submit a Github PR and I’ll get that in front of the right team.
Best,
Cody
Thanks, Cody. I’ll consider making a PR on git-hub. Note that I just added yet another bool: UCollectionSettings::bAutoCommitOnCreate. This prevents the collections API from auto-committing to perforce when a new collection is created. Rather, the file gets created and marked for add, but the submission step is skipped.
I didn’t know that preventing these final submission steps posed deeper complications in the rest of the editor. I suppose we’ll find out further when it bites us. For now, we just can’t have it submitting to perforce on its own. We need the user to control that.