Blueprint reviews and flush async loading

Development Pipeline & Plugins
, ,
1

Hi,

When reviewing BP changes, quite often they are checked in with lots of actors in the level which makes the review tool very painful to use becuase it seems to load all of them as soon as they are visible in the Review Changelist window, instead of loading them if I actually try to diff them.

Since it’s a WP level those actors also are always placed ontop (since they are in __ExternalActors) making it worse since I’m not really interested in review actors that have moved around in the level, I want to see the BP logic changes. Scrolling down to them can take several minutes because the editor keeps freezing (because of FlushAsyncLoading).

Is there any easy way of chaning this behaviour locally?

Are there any plans on improving this workflow? I find the review tool to be very useful and I use it a lot, but it is becoming harder and harder to use because of this behaviour.

Best Regards

Roger

2

Hi Roger! Great feedback! Unfortunately we don’t have the dev resources for this right now but it should be achievable for you to implement these changes yourself if you have a desire to do so! the relevant code is in Engine\Plugins\Editor\ChangelistReview\Source\Private\SSourceControlReview.cpp and Engine\Plugins\Editor\ChangelistReview\Source\Private\SSourceControlReviewEntry.cpp. To speed up loading, you can try finding ways to avoid calling DiffUtils::LoadPackageForDiff until the user clicks the file and to sort them the way you like, you should be able to adjust their order in the SSourceControlReview::ChangelistEntriesWidget.

Hope that helps! If you end up making any changes that you think would be good to use as official features, feel free to send me a pull request and I’ll review it.

3

Thanks for the info :slight_smile: