Hi everyone,
I can’t open an issue on github. I’ve come across these links but none of them is what i’m looking for
https://answers.unrealengine.com/spaces/11/bugs-and-crashes.html
What if i want to report something other than a bug? Maybe suggesting a change that will imrove code quality etc.
Should i make a pull request in these kind of situations, is there a way i can open an issue?
For instance, unused local variables.
void UAnimStateNode::AllocateDefaultPins()
{
UEdGraphPin* Inputs = CreatePin(EGPD_Input, TEXT("Transition"), TEXT(""), NULL, false, false, TEXT("In"));
UEdGraphPin* Outputs = CreatePin(EGPD_Output, TEXT("Transition"), TEXT(""), NULL, false, false, TEXT("Out"));
}
or this one, FoundInputs variable is unused.
int32 USoundCueGraphNode_Base::GetInputCount() const
{
int32 InputCount = 0;
for (int32 PinIndex = 0, FoundInputs = 0; PinIndex < Pins.Num(); PinIndex++)
{
if (Pins[PinIndex]->Direction == EGPD_Input)
{
InputCount++;
}
}
return InputCount;
}
or this piece of code which rests in SGraphPanel::OnPaint
const SNodePanel::SNode::FNodeSlot* CommentSlot = ChildNode->GetSlot( ENodeZone::TopCenter );
float CommentBubbleY = CommentSlot ? -CommentSlot->Offset.Get().Y : 0.f;
Context.bSelected = bSelected;
TArray<FGraphInformationPopupInfo> Popups;
{ /* why use curly brackets here ? to reduce scope of a function call? */
ChildNode->GetNodeInfoPopups(&Context, /*out*/ Popups);
}
for (int32 PopupIndex = 0; PopupIndex < Popups.Num(); ++PopupIndex)
{
FGraphInformationPopupInfo& Popup = Popups[PopupIndex];
PaintComment(Popup.Message, CurWidget.Geometry, MyClippingRect, OutDrawElements, ChildLayerId, Popup.BackgroundColor, /*inout*/ CommentBubbleY, InWidgetStyle);
}
Another one is that every time i have to check to see if a TArray is empty i have to write this.
TArray<int> Arr;
/**/
if (Arr.Num > 0) {}
instead of this
if (!Arr.IsEmpty()) {}