I’m sure this may be a common question. I have some pull requests that have been looked at and either approved or rejected. I also have a pull request that hasn’t been looked at in about 6 months but is marked for review. There is a huge backlog and I know everyone at Epic is busy. Should we try pinging some people if we want to get attention on something?
No idea. You could try commenting on it to see if it brings up someone’s attention. A small PR has higher chances of being merged. Large PRs full of new features are less likely to be picked up because it means someone at Epic has to go through the whole thing and make sure it’s kosher.
Hi illYay,
Every pull request that is received has an internal tracking ticket created for it. That ticket is then assigned to one of our engineers to review. The time that it takes for a pull request to be reviewed depends on a number of factors. As Manoel.Neto mentioned, size and complexity of the pull request has an impact on this time. However, there are other factors as well that can have a significant effect on the review time, such as the current workload of the engineer that needs to review the pull request, as well as the current and future plans for the particular part of the Engine that the pull request is changing. Unfortunately in a lot of cases it is difficult to provide an estimate for how long it will take to review a particular pull request.
It is also possible that the ticket for a pull request can get lost in the clutter of other bug tickets that need to be looked at. If you want to occasionally ask for a status update on your pull request, you can certainly do so. We can check the tracking ticket to see if it is possible to get an update on the status of the review, but would not be able to make any guarantees that it would be reviewed immediately. It is also helpful if you are able to periodically update your pull request to make sure it stays current with other changes that have been made in the surrounding Engine code since the pull request was opened.
I’ve been thinking about adding to the PR to make sure it still works with the latest version. Will posting updates/comments on the PR itself bring attention to it or should I send a ping in email somehow?