“Is the weapon pickup system I’m using good, or can additional features be added?”
PART1
PART2
it really depends on your game design but since you have a direct reference to the FirstPersonCharacter there is no need to Loop over the components just have a variable on the character bHasWeapon?
Personally I’d create a new collision object channel to apply to the pickup item.
From there I’d go to the character class and create an Actor Obj reference variable to store reference of the weapon the character has. Then implement an interface to retrieve the relevant response if it has a weapon or not.
Interface function would be as simple as get Weapon actor is valid.
Back in the character class, open the BPI Weapon function IWep Has Weapon (dbl click on it).
Take the Wep Actor Ref and run an is valid on it. Pipe the pins to returns and set the bool as needed.
Now back in the pickup item class we handle the overlap logic.
When you spawn/attach the weapon to the character you need to set Wep Actor Ref variable. When you drop it, clear the variable.
Results ::
-
Only the character class can trigger an overlap on the item collision. This reduces the overlap triggering and executing logic for every possible thing it could be overlapping at any given point in time.
-
Pick up item doesn’t have to cast, nor reference the character class ever. Casting creates a hard references in memory.
When you cast to a class your essentially loading the entirety of that class and any classes it references in to the owning class.
E.g. your character class references your controller class which references the player state. If your item class at any point casts to the character class it’s loading the character, controller and player state in memory to your item class.