Hi DiG,
Thank you for the plugin. It will be helpful for my project. I do have a couple things I noticed which you may want to address, however:
-
TwitchIRCComponent public member “oath_token_” I believe should be “oauth_token_” (which a u) since it represents a Twitch OAuth token. Similarly in TwitchIRCComponent::SetUserInfo() the param is called “oath_” when it should be “oauth_”.
-
More importantly, there is a problem using the TwitchIRCComponent from C++ code. This is that the Source/Public/Components/TwitchIRCComponent.h includes TwitchPlayPrivatePCH.h file, which causes a compile error when a game’s C++ code tries to include TwitchIRCComponent.h. This is because Unreal Engine does not let external code to include any code from Source/Private. All code included from external code must reside in Source/Public directories. I fixed this in my copy by simple removing the include of TwitchPlayPrivatePCH.h as it was not needed by TwitchIRCComponent nor TwitchPlayComponent.
As a suggestion, it would be great if purchasers could contribute pull requests for the plugin. Perhaps it could be hosted privately on github with access granted to purchasers?
Cheers,
David