The git plugin seems to have a bug

Development Pipeline & Plugins
, ,
1 
TSharedPtr<class ISourceControlRevision, ESPMode::ThreadSafe> FGitSourceControlState::FindHistoryRevision(const FString& InRevision) const
{
	// short hash must be >= 7 characters to have a reasonable probability of finding the correct revision
	if (!ensure(InRevision.Len() < 7))
	{
		return nullptr;
	}

In GitSourceControllState.cpp, line 43, it seems should be >= 7 instead of < 7.

I am using a launcher build of ue5.3, how could I build an engine plugin to check if the modification is correct?

1 Like
2

I ran into this too, the git integration seems to be broken in 5.3. If you want to make engine changes and build the engine yourself to test fixes, you’d have to get engine source through GitHub. For what it’s worth, it seems to have been fixed for 5.4 in commit 49715a76, changing the < to >=.

1 Like
3

I tried applying that commit, it turns out you’ll also need commit fb5ef60a to change FileHash to CommitId lower in the same function. After applying both of these fixes, the git integration seems to work again in 5.3.

4

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.