Am pretty excited today because I modified Engine source to add a feature I wanted. Its called Blueprint Lock Node feature. Basically what it does is, prevents the user from accidentally deleting any nodes.
Does the locked status save too or is it just per-session?
That would be handy when distributing Blueprint based content to other people to prevent them deleting important nodes accidently.
Easy, from your local clone of epic/master (you have one right?) make a branch: git checkout -b master_bp_lock_pr then make your BP lock node changes to files in this branch and commit them. Push this branch upstream to your github then run PR against epic/master from that new upstream branch.
Grab Git Bash from here Git - Downloading Package and install it in the context menu so you can right click inside any folder to open up a shell.
What?
You don’t use command line? Geez Louise!
Then you need to setup VS for this but to me it seems like a long winding process. In command line this would take all 3-4 lines to complete. Easy!
I saw your PR on github but I’m just confused as to what was the source, it says unknown repository? Also, I do not see your committed changes either.
clone epic/master from github to my computer using terminal (since I was coding in Linux)
locally branch off epic/master that I cloned above to a new branch 3dluvr/master_pr_for_epic_xx
make changes to files in 3dluvr/master_pr_for_epic_xx and commit them
push 3dluvr/master_pr_for_epic_xx up to my github repo
using a web browser run a PR (green icon next to the branch name on github.com) against epic/master from my 3dluvr/master_pr_for_epic_xx directly that I pushed previously
bug the hell out of epic|rcl on the IRC to merge my PR (optional)
This way the only changes showing would be the ones I made and not any of the commits Epic devs made. It makes it easier for them to merge the PR and reduces clutter.
So i selected promoted branch and clicked that green PR button and selected compare across forks. Now am here in this page. Should i just click Create pull request?
Yes that’s the process, although I would not use epic/promoted - that is the internal branch their artists and designers use.
Instead use epic/master, being the bleeding edge code, you are most likely to get your PR accepted. Epic can backport the code to lower branches from master if they want to.
You cheated I see ryanjon2040/promoted against epic/master, that’s why you have so many extra commits and it’s really not the right way of doing it.
As I said above, promoted is a derivative of master but using it for PRs is not really advisable as it gets things from upstream (master) not vice versa.
You do want Epic to accept your PR, right? Gotta make it easy for them to do so and presently they need to do figure out your changes from the rest.
I see ryanjon2040/promoted against epic/master, that’s why you have so many extra commits and it’s really not the right way of doing it.
