macros vs functions (One breaks my map, the other doesnt)

The for each loop is an example of a useful macro.

What is your map macro in the function? curios why it wouldn’t populate