While sleeping, I thought of some options:
a. Create a pull request by adding just the comment: “This function is not called from anywhere at now”
- I know that this could sound ridiculous.
But I learned that sometimes just only comment is needed.
b. Create a pull request by deleting that function:
- I know this could be overkill. But that function was a very good trap to step on.
c. Create a pull request by adding below:
- Add a variable of the FGraphNodeFactory in SGraphNode.
(Maybe like “TSharedPtr<FGraphNodeFactory> NodeFactory”) - In SGraphPanel::AddNode(), if SGraphPanel of SGraphNode is valid,
write that to the variable above inside the node in adding. - When SGraphNode makes pins through the SGraphNode::CreatePinWidget(),
if the variable of the FGraphNodeFactory is valid,
SGraphNode will try to use the FGraphNodeFactory::CreatePinWidget() at first.
If failed, then call FNodeFactory::CreatePinWidget() as same as past.
- I am not sure that it is wise to add the variable of FGraphNodeFactory to SGraphNode.
d. Forget it all.
- The easiest way, but uncomfortable to me. But there is no way to know the intent of the Epic on these codes for me. Maybe they have some schedule or plan to modify those codes. So it could be most safe.
What will be the best?