Engine crashes on any asset modify with Git source control on

Development Programming & Scripting
1

Hey,

The Git source control plugin currently consistently crashes on any asset change: whenever I modify an asset name (in engine), move an asset, fix up redirections in folder, delete etc. - A popup status saying “Updating in source control…” appears, and Unreal Crashes.

Example dump for delete operation after redirection fixup:

Access violation - code c0000005 (first/second  not available)

""

UE4Editor_GitSourceControl!FGitSourceControlProvider::Tick()
UE4Editor_GitSourceControl!FGitSourceControlProvider::ExecuteSynchronousCommand()
UE4Editor_GitSourceControl!FGitSourceControlProvider::Execute()
UE4Editor_GitSourceControl!FGitSourceControlProvider::GetState()
UE4Editor_GitSourceControl!ISourceControlProvider::GetState()
UE4Editor_UnrealEd!ObjectTools::CleanupAfterSuccessfulDelete() [d:\buildfarm\buildmachine_++depot+ue4-releases+4.8\engine\source\editor\unrealed\private\objecttools.cpp:1408]
UE4Editor_UnrealEd!ObjectTools::DeleteObjectsUnchecked() [d:\buildfarm\buildmachine_++depot+ue4-releases+4.8\engine\source\editor\unrealed\private\objecttools.cpp:1684]
UE4Editor_UnrealEd!FAssetDeleteModel::DoDelete() [d:\buildfarm\buildmachine_++depot+ue4-releases+4.8\engine\source\editor\unrealed\private\assetdeletemodel.cpp:256]
UE4Editor_UnrealEd!SDeleteAssetsDialog::Delete() [d:\buildfarm\buildmachine_++depot+ue4-releases+4.8\engine\source\editor\unrealed\private\dialogs\sdeleteassetsdialog.cpp:683]

Note: in my setup, the git repo is located two folders above the Unreal Project path.

The solution I currently have to not use source control inside the engine. Which is ok, because I’m the developer. The rest of my team, however, has been shooting nerf darts at me.

2

I’m getting the same thing with 4.8.1. Hoping to get a solution, cause its super annoying.

3

Same for me with UE4.8.1, Win7, VS2013 and git 1.9.4

4

Hi everyone,

The callstack in this post appears to be the same as what I received when reproing the issue reported here. That issue deals specifically with deleting assets, and has been reported in UE-19074. I was not able to get any crash when moving/renaming assets. If you have any additional information that would help us reproduce a crash in those instances, please let us know.

5

Steps for recreating crash, works for me every time so far:

Start with a project that isn’t Source-Controlled. Put something in it.

  1. Create git repo ( git init etc…) and sync it to github. Commit the entire project. I used this .gitignore (mind you, it’s a big project that had a Unity project under the same folder, which was ignored).
  2. Open the project in the editor.
  3. Before connecting to source control, add an asset, like a static mesh.
  4. Under source control, set up the local git repo.
  5. Move, Rename or Delete the asset you added at step 3.
  6. Your computer is now on fire.

Step 3 doesn’t necessarily have to happen with unversioned files, but this is a very easy way to recreate the error.

6

Hi FakeLoveOmer,

I tried to reproduce the crash using the steps that you provided, and was unable to do so. Everything seemed to be working fine for me. Here’s what I did:

  • Create a new Blueprint project using the First Person template in the binary version of the Editor.
  • Using Git Shell, ran git init on the project folder.
  • Copied the .gitignore file that you said you were using and added it to the project folder.
  • Opened the GitHub Windows client and added the project repository.
  • Performed initial commit in the GitHub Windows client and published the repository to GitHub.
  • Opened the project in the Editor.
  • Imported a new static mesh FBX file into the project (it created two new uasset files, a static mesh and a texture).
  • Saved both new uasset files.
  • Clicked Source Control → Connect to Source Control…
  • Selected Git as the Provider, verified the Git Path that was automatically filled in pointed to my git.exe file, and the Root was automatically filled in with my project folder.
  • Clicked Accept Settings and received a notice that the connection was successful.
  • Renamed the new static mesh uasset, which was then marked as needing to be checked in.
  • Right-clicked the uasset and selected Source Control → Check In.
  • After the check-in completed successfully, synced the commit to GitHub using the GitHub Windows client.

Unfortunately the Editor did not crash for me at any point. I even tried changing the name of both of the new uasset files, and that did not cause a crash either. Do you see anything different in what I did compared to your process?

7

Nope! That was pretty much my process (only with a code project). Mine crashes upon any asset rename, move, redirection fixup or delete.

We’ve switched to SVN because of this, but I’m happy to share more info if you contact me by email.

8

Would it be possible to get the callstack that you are seeing when this crash occurs?

9

Hi FakeLoveOmer,

I just wanted to let you know that we have a fix in place that we believe will resolve the crash that you were seeing. I have not yet had a to test it for the crash when deleting an object, but since the callstacks are so similar we expect this should resolve the crash that you were seeing as well. When I have a to test it, I will let you know.

10

I just wanted to provide a quick update. I have re-tested the crash that I was able to reproduce in one of our latest internal builds, and the crash no longer occurs. This was the test that involved deleting an asset, but we believe it will also correct the other crashes that you were experiencing.

If you have built your Engine from source code, the fix that we implemented can be found here. If you are using the binary version of the Engine, this fix will be included in a future release version of the Engine.

11

I am also crashing on 4.8.3, but on asset import - usually when doing a bulk import of 2 or more at a time. No crashes occur when importing one asset at a time.

Was this resolved in 4.9? Many thanks!

12

Hi JDuaneJ,

The fix that I mentioned in my previous comment (August 13th) was included in 4.9. We believe that fix will have corrected all of the crashes when assets were modified while using the git plugin. However, the only crash we were able to definitively reproduce and verify to be fixed was caused when deleting assets. If you upgrade to 4.9 and continue to experience these crashes, please let us know.