Code Critique?

[anonymous_user_84df80f6]

Hello, I am currently working on a RPG, and before I go any further, I would like for y’all to critique my code.

Normally, I would request this on something like codereview.stackexchange, but I’m fairly certain they aren’t familiar with Unreals API, so I figured it might be better to post in the C++ forums.

Here is the repository: /RPG

Thank you to those who do critique.

[ExtraLifeMatt]

It’s hard to critique an entire code base, everything looks pretty standard and if it is working for you then keep it up.

That said, I checked out your PlayerPawn.cpp and noticed a few things:

In APlayerPawn::GetLevelUp()

UDataTable* LookUpTable = nullptr; // This is being set to null
const FLevelUpData* Row = LookUpTable->FindRow<FLevelUpData>(RowToFind, “blah blah blah”); // But then immediately accessed here. This will crash.

In APlayerPawn::SearchForTargets()

//Since Get all actors of class will hit our actor, if we only hit ourself, do not run this piece of code.
if (Targets.Num() == 1) // The comment above says NOT to run the following code if there is only one target, so this should probably be !=
{

	for (int32 i = 0; i < Targets.Num(); i++) 
             {

There’s probably more, but honestly I would say in general you’re doing fine and to keep pressing forward until you hit a specific issue/question.