Blueprint Bubblesort doesn't work correctly

[Raildex]

Hey there.

I hope Code Review/Assistance is allowed here.

I have an array of Integers. These Integers are actually indices of an array.
These indices point indirectly onto items. These Items have an ID. The *indices *should be sorted by this ID.
For a test, I have 4 Items with the IDs
1
2
4
1021

But after sorting, the indices are
1021
1
2
4

I’m pretty sure my Bubblesort is ok and does not have any errors.

This is the Comparator

This is the Sort

Did I miss something? Becaus I feel pretty stupid at the moment.

[MrGoatsy]

You didn’t attach the B node:

[Hyperloop]

There’s a get max value of array function in blueprint that you can use to simplify the sorting immensely. Here’s an example setup (not mine).

Obviously you’d need to tweak this to build the correct array, but you get the idea.

[Raildex]

@MrGoatsy;571757

You didn’t attach the B node:
http://i.imgur.com/BJ7q9tk.png

It is attached, it’s just a reroute node.

@Hyperloop;571773

There’s a get max value of array function in blueprint that you can use to simplify the sorting immensely. Here’s an example setup (not mine).

Obviously you’d need to tweak this to build the correct array, but you get the idea.

I’m not sorting the int array itself. so this doesn’t help me.

The content of this array are actually Indices of an array.

IndexArray->Int->Index of Item in the Inventory -> Index -> Item -> ID

I want to sort the Items by ID.

[Hyperloop]

As long as you perform the operation on the correct array, or set of arrays you can still do that easily.

Check out this picture:

“Raw Distance” is an array of floats which corresponds to the array “Chunks”.

After I loop through this, ChunkIDByDist will be sorted in ascending order by the values in “Raw Distance”.

[Raildex]

I guess you misunderstand me. I don’t have an array of ints or something like that.

I want to sort the Indices (left) by the ID (green)

[Dementiurge]

@Raildex_;571616

This is the Sort

Looks like this could potentially try to access an index greater than the length of the array. The first setarrayelem has an opportunity to set Item to array.get(arraylength), which is the element after the last element in the array. I tried implementing these nodes and blueprint would crash silently.

By comparing A with B, but swapping A with A+1 (which could be completely different index from B), I’m not sure the result is actually getting sorted.

And then you need to run the bubble sort repeatedly, because one pass of bubble sort won’t be enough.