Hi, I’ve taken a look at your post and it all looks okay to me. My set-up is not much different to yours actually, perhaps mine is slightly simpler than yours as I’ve not got round to adding a bunch of the synth parameters as of yet and am only using a single oscillator at the moment. The reason I’ve not really done much with the synth module in this project so far is because I’ll end up spending more time tweaking parameters and listening to the cool sounds that it produces than I would spend developing the actual music generation logic 
Okay, so the main differences between your synth setup and mine are as follows:
I’m triggering my synth module via timer based events rather than an input event and I’m passing a duration value to ‘note on’ so I don’t actually ever call ‘note off’ but these are obviously decided based on the project requirements and the way you’re doing it is more fitting for your purpose. Other than that, I’m setting all my synth parameter values at run-time via the tick event. I’ll probably change this at some point to be set either by a custom event or a function call…either way as long as I can change these at run-time I’m happy.
Regarding the music generation logic, it’s not too dissimilar to what you are doing…I’m literally grabbing a random value from an array of note values and passing it to the synth. I’m not happy with it yet though and I’ve got a long way to go before I will be. I’m comfortable working with audio itself but I’m a complete amateur when it comes to music theory and composition so there’s much for me to learn before this sounds humanized
