Need help converting this blueprint to C++

[OneShotGG]

@mikepurvis;476616

That’s not going to work. You are Iterating on APlayerController and then trying to cast it to a ASBaseCharacter. Unless you have extending PLayerController with your character class name which would be really confusing. Iterate on the Characters, or Get the ControlledPawn from the Controller and then cast that result.

Yes on the loop simplification, that’s what I meant. You can do it all in one shot. Sugestion though is initialize the pointer to 0 at the start and make sure you test the result because it can be NULL.

Ok so I see what you are saying.

@UnrealEverything;476626

Yes, MUCH better

Although there are still more things to consider.

First of all in a scenario when there are no PlayerControllers (yet), the loop body will never run. This could be an issue since you return ClosestPlayer which never had any value assigned explicitly. So it could contain garbage and upon trying to access anything through the pointer lead to a crash. Simply initialize it to NULL or nullptr and you should be safe (as long as you check whether your pointers are valid).

Something that shouldn’t really harm but is also not really useful in any way is the additional “if (!ActorItr) return;”. You’re already checking whether your iterator is valid in the loop condition (ActorItr;) and if it isn’t then you didn’t enter the loop body in the first place. And to answer your question in the comment in that line: Yes return will break out of the function and return the result (which you haven’t specified at this point) to the point where GetClosestPlayer has been called from, but you will not get to this point at all if there is no PlayerController found (see above).

EDIT (in response to mikepurvis):
The PlayerController isn’t what’s being casted here. It’s the PlayerController’s Pawn: ActorItr->GetPawn().

And something I forgot to mention: You should be able to simply replace TActorIterator<APlayerController> with TActorIterator<APawn> and this should allow you to iterate over all Pawns instead of all PlayerControllers.

If I use APawn it will also find the AI but if I use a Tag for player I should be able to make it work that way.

So it will

Find all Pawns -> Exclude Pawns without the Tag Player (using if statement) and then do everything needed.

My question revolves around performance. Because I need to constantly update a zombies target I am running this on tick. If I am searching for all pawns in the world every frame (which could be up to 100 or more) wouldn’t that be pretty slow or at the very least destroy performance?

I’ve been thinking about this issues and wondering if I should limit the area the Zombie can search (on tick) or use sensing component to only check distance while multiple characters are sensed (use onHearNoise, OnSeePawn).

edit: Just to let you know I made the changes yall pointed out and it works awesome. Thanks for the help!