Collapsing nodes is not the same as making a function. A function is for re-usability.
I do this too, but the suggestion for material function libraries is just to have more consistency between the different tools.
Thanks for all the suggestions, I will merge them in my post later today so we will eventually get one big pile of suggestions 