[Feedback wanted] Multi-purpose item struct

[SaxonRah]

@DevSaucy;445355

Hi, I’ve put together a nested multi-purpose item struct I’d like some CC/feedback on.

I’m trying to cover all bases I could think of when I think what an “item” is in UE4. An item in my eyes is a: weapon, tool, potion, armor, etc.
Trying to cover 2D and 3D as well: a 2D item would have a sprite (I’ve included possible animation struct too), a 3D item would have a mesh.

I wanted to define all items in a struct (without being inside a blueprint and fiddle about), because that way I have better eye on things.

http://i.imgur.com/NYjY3Tp.png - I’ve tried color-code so it’ll be easier to find where and what goes where.

So when I want to create a new item, I’ll just need to add it into the Items struct and change the values I want to use then it’s ready to go!

Does this look any good? Would you use or think of using something similar?
Why? Why not?

Feel free to ask questions.

Thanks

An item is much more simple than a potion or weapon. The Item is the base underlying thing that represents an item. In your case an item is a struct with many parameters that has struct with many parameters that has a struct with many parameters, all of the structs have states (bools). allot of functionality that is unnecessarily grouped. Don’t make an item that has everything, make an item that has the most basic of functionality and then inherit that item to build specialized ones from it.

for example why does items_params have weaponstats, if the item is a potion ? Object orientation is your friend.