To be clear, I am pointing out that at a glance it looks like the change to the ExternalCancel() function doesn’t make a lot of sense in context; which is why I am asking clarification questions to know if there is a deeper meaning, intention or context I am not aware of looking at the code at a glance.
By your earlier post the point of the if (ASC) isn’t meant to shadow the OnAbilityCancelled(); function call; so the if-statement doesn’t seem like it’s doing what’s intended in that function and probably should be removed/omitted entirely or changed back to check(…).
Because to be clear it absolutely is in fact shadowing OnAbilityCancelled(); An if-statement without brackets just means the next statement is what’s in the if’s scope; which is OnAbilityCancelled();.
Because an if-statement isn’t the same thing as check(), check throws an exception afaik if the object pointer being passed in is null. So if the goal is to make sure the pointer isn’t null and throw an exception if so then it should stay as check(…).
Do you understand what I’m saying? I isn’t really important “what” the change was at this moment, the problem is that this particular suggested change in the upgrade to 5.1 doesn’t make a lot of sense or match the original intent; unless I’m wrong and there is a deeper intent I am missing.
If I’m not wrong then the guide I’d suggest you edit to reflect the suggested change for clarity.