C++ Newbie - Please judge my C++ code.

[NegInfinity]

@Jamendxman3;412779

That does not work properly with negatives (for what I need anyways), and it would be simpler to do the data type conversion than use Ceil or Floor based on it’s sign.

Thanks for your suggestions everyone, I ended up simplifying it quite a bit, and even learned a few things in the process (Ternary Conditional Operators), here is the new code:

void UCustomBlueprintNodes::SnapVectorToGrid(FVector Vector, float GridSize, FVector& SnappedVector)
{
	float SnappedX;
	float SnappedY;
	float SnappedZ;
	FVector AbsVector = FVector(FMath::Abs(Vector.X), FMath::Abs(Vector.Y), FMath::Abs(Vector.Z));
	SnappedX = (float)((int)(Vector.X / GridSize))*GridSize;
	SnappedY = (float)((int)(Vector.Y / GridSize))*GridSize;
	SnappedZ = (float)((int)(Vector.Z / GridSize))*GridSize;

	if (FMath::Fmod(AbsVector.X, GridSize) >= GridSize / 2)
	{
		SnappedX += GridSize*((Vector.X < 0) ? (-1) : (1));
	}

	if (FMath::Fmod(AbsVector.Y, GridSize) >= GridSize / 2)
	{
		SnappedY += GridSize*((Vector.Y < 0) ? (-1) : (1));
	}

	if (FMath::Fmod(AbsVector.Z, GridSize) >= GridSize / 2)
	{
		SnappedZ += GridSize*((Vector.Z < 0) ? (-1) : (1));
	}

	SnappedVector = FVector(SnappedX, SnappedY, SnappedZ);
}

I advise to review my previously posted code snippet.

FVector snap(FVector arg, float gridSize){
	auto f = &](float val){
		return gridSize ? (float)round(val/gridSize)*gridSize: val;		
	};
	return FVector{f(arg.X), f(arg.Y), f(arg.Z)};
}

First, code duplication should be eliminated in almost all cases. You have three if/else branches doing the same thing, but on different fields of the structure. This stuff belong to another function or lambda. Duplication results in bugs and increases maintenance costs.

Also, cmath library has round() function, which rounds float/double value to the nearest integer.
Your code does the same thing as this builtin function, so you’re reinventing the wheel. That is a bad practice.

Using round(), you can replace convoluted if/else with

snappedValue = (float)round(val/gridSize)*gridSize;