Announcement

Collapse
No announcement yet.

Pull Requests

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • started a topic [PROGRAMMING] Pull Requests

    Pull Requests

    I was roaming through all of the awesome pull requests on Github and I am amazed that nothing has been merged since June. Epic, you have a community that wants to help make your engine better...yet, no one has paid attention to the PR's. With the influx of Fortnight and investor cash, maybe hire additional personnel to help incorporate changes into the engine? Or, maybe once a month have Pull Requests Friday's... Have all of the engineers review at least one PR. <- Too simplistic, but you get the point. Basically, add some urgency...

    teak
    Last edited by teak421; 11-06-2018, 11:21 AM.

  • replied
    Originally posted by project.gheist View Post
    If they would have hired me it would have roughly decreased by 1/6th ‚Äč
    I'm surprised they didn't yet, honestly, you made more quality-of-life changes in the past time than Epic


    Originally posted by Cheshire Dev View Post
    Well, most of the PRs with more than 2 lines of changes are usually ignored for a very long time. Whenever it's reviewed by a dev, the response is always great - clean, detailed description about why it was accepted or declined. However, many issues are months and years old, and many of them were never looked at with more than a "Waiting for review" (Meaning "We might take a look at it in the next 10 years") or "Backlogged" (Meaning "You can even remove it, going to ignore it forever") badge. It can demotivate the capable ones from contributing.

    But the problem might be wider than just the handling of PRs, I think it's the handling of the community. Just look at some long-standing issues like categories for the Vault in the launcher, or literally 3 years old, trivial BP and UMG issues with a hundred votes, ignored not-even-demanding features requested twenty million times, while implementing features instead, that will only be relevant to like 0.001% of the community (they are great, but why are they the priority?). In many aspects I really love Epic, UDN responses are great, many staff members are on the forums and are being active, it's awesome that they always give something to the community, let it be Paragon assets or free Marketplace items. However, I'm not sure if it's enough. Imagine giving a child a new toy every day, but never listen to him whatever he says. I think she would be much happier by having their parents around instead of having a bunch of toys. I'm not saying it's a perfect mirror, but I hope you see my point. I don't really see the developers having any voice in the decision making, Epic seems to work on whatever they think is important, and all you can do is discuss hacks around problems which should be part of the engine.

    Of course it's not always so dramatic But, well, this is how one might feel sometimes.
    Last edited by KristofMorva; 11-07-2018, 12:59 PM.

    Leave a comment:


  • replied
    Originally posted by Cheshire Dev View Post

    That's simply not true.
    https://github.com/EpicGames/UnrealE...bel%3AAccepted

    Of course, I'd love to see more pull requests to be accepted. The problem is probably that you can't simply hire people working exclusively/mostly on PRs. You need to assign a Sequencer programmer to Sequencer-related PR to minimize risk of messing up something...
    If they would have hired me it would have roughly decreased by 1/6th

    Leave a comment:


  • replied
    Originally posted by Cheshire Dev View Post

    That's simply not true.
    https://github.com/EpicGames/UnrealE...bel%3AAccepted

    Of course, I'd love to see more pull requests to be accepted. The problem is probably that you can't simply hire people working exclusively/mostly on PRs. You need to assign a Sequencer programmer to Sequencer-related PR to minimize risk of messing up something...
    Yep, you are right... I must have done something wrong on the search.

    teak

    Leave a comment:


  • replied
    Originally posted by teak421 View Post
    I was roaming through all of the awesome pull requests on Github and I am amazed that nothing has been merged since June.
    That's simply not true.
    https://github.com/EpicGames/UnrealE...bel%3AAccepted

    Of course, I'd love to see more pull requests to be accepted. The problem is probably that you can't simply hire people working exclusively/mostly on PRs. You need to assign a Sequencer programmer to Sequencer-related PR to minimize risk of messing up something...

    Leave a comment:

Working...
X