looks like source control was blocking me :
SourceControl: Error: The following paths are ignored by one of your .gitignore files:
SourceControl: Error: Build/Mac/Application.icns
SourceControl: Error: Use -f if you really want to add them.
Simply modifying the folder so that it was included allowed the icon to be set as would be expected through the ui