Announcement

Collapse
No announcement yet.

How to get pull requests reviewed and accepted?

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • How to get pull requests reviewed and accepted?

    Hi,

    I work for a medium sized developer, with 30+ coders - and we've made some good fixes to the engine. Ideally we would like to push these changes back to Epic so that other people can benefit from them, and also will prevent merge conflicts for us at a later date.

    I have submitted 2 pull requests for very simple fixes (as a starting point), but both are just sitting in "Waiting for Review" state - one of them since July.

    Is there any way to raise the profile on pull requests? Or perhaps I'm missing a step?

    https://github.com/EpicGames/UnrealEngine/pull/3799
    https://github.com/EpicGames/UnrealEngine/pull/4066

    Thanks,

    James

  • #2
    Same here. One of my PRs is awaiting Review since august 13th
    AFAIK there's no way to speed up the review process. Epic simply picks the most interesting ones or critical bug fixes.
    One thing I noticed is that the review process slowed down massively around may 2017. Before that, it took 1-2 months to get a review. The reason is unknown, at least to me

    Comment


    • #3
      Hi @James Chilvers, it seems that you've had one of them pass the review three days ago, congrats!

      I've had a ton of merge requests accepted, so here is my opinion on the way to do it:
      1. you should give many informations, like (at least some of these depending on the context):
        1. precise description of the issue (look at what they use internally, for instance #UE-44637),
          1. best start would be to link to a previously made bug report on AnswerHub (or existing issue on the public Epic Game tracker)
          2. steps to reproduce
          3. perhaps even a minimum test case project
        2. an explanation on what was fix/how it works
        3. what non-reg tests where done/are there any risks involved
      2. the fact is after a few one on the same subsystem you become known as somehow reliable (sort of) so this become quicker/easier
      UE4 Git LFS 2.x Source Control Plugin v2.4 for UE4.18 - (v1 integrated by default in Beta status since UE4.7)
      UE4 Plastic SCM Source Control Plugin (1.0.6 for UE4.18)
      PayPal me a beer to support my work

      Comment


      • #4
        Originally posted by TriNityGER View Post
        Same here. One of my PRs is awaiting Review since august 13th
        AFAIK there's no way to speed up the review process. Epic simply picks the most interesting ones or critical bug fixes.
        One thing I noticed is that the review process slowed down massively around may 2017. Before that, it took 1-2 months to get a review. The reason is unknown, at least to me
        Probably Because Andrew Pascal Left https://twitter.com/UnrealAlexander everything seems to have been going downhill since he left, also the live streams aren't the same anymore without him

        Comment


        • #5
          Considering the number of active pull requests just keeps rising, most of them are never reviewed or accepted. It's sad.
          Last edited by Zeblote; 11-15-2017, 10:33 AM.

          Comment


          • #6
            Originally posted by James Chilvers View Post
            Hi,
            I work for a medium sized developer, with 30+ coders - and we've made some good fixes to the engine. Ideally we would like to push these changes back to Epic so that other people can benefit from them, and also will prevent merge conflicts for us at a later date.
            It's best if you just submit all of your changes where you think it makes sense. It's not just Epic looking at the PRs, but also other programmers that look through the PRs to find interesting stuff that makes sense to merge because it would improve performance or stability. If I find something interesting, I merge it into my branch of course. So even if Epic doesn't immediately accept the PRs, you are still helping other people a lot with them. Nothing is better than having an issue and finding a PR that just fixes it

            And yes, Epic is a bit (very) slow with PRs recently. They just don't have enough people looking over them. At some point they will probably dedicate more people to that again (I hope).

            Easy to use UMG Mini Map on the UE4 Marketplace.
            Forum thread: https://forums.unrealengine.com/show...-Plug-and-Play

            Comment


            • #7
              Yes I am pretty sure they will put more priority into it again at some point, like they did in the past.

              Meanwhile, I've look at a few open PR, and let's be honest, we could/should largely improve the minimum quality (some titles just say "Fix a small bug" or the like)
              UE4 Git LFS 2.x Source Control Plugin v2.4 for UE4.18 - (v1 integrated by default in Beta status since UE4.7)
              UE4 Plastic SCM Source Control Plugin (1.0.6 for UE4.18)
              PayPal me a beer to support my work

              Comment

              Working...
              X