Annoying compile issue in 4.17 preview 3

[Ben Marsh]

QFEs can be downloaded here:

Windows:
http://cdn.unrealengine.com/qfe/QFE-...ob-7937603.exe

Mac:
http://cdn.unrealengine.com/qfe/QFE-...ob-7937603.zip

[Ben Marsh]

Thanks Ben. Could you also just quickly have a look into the issue I posted above yours? I'm not sure if it's related, but improved logging there would have made it much easier to fix!

Absolutely, will do. We should never be crashing without an explicit error explaining the problem.

[Ben Marsh]

Thanks Ben. Could you also just quickly have a look into the issue I posted above yours? I'm not sure if it's related, but improved logging there would have made it much easier to fix!

I've submitted a fix for this to a development stream, but it's not visible on GitHub yet. We'll include it in the 4.17.2 hotfix (we've already stopped taking changes for the 4.17.1 hotfix to try and get the other issue on this thread out of the door). The fix is to insert a check that the Instance.Modules list doesn't already contain a module in the UEBuildTarget.AddPlugin function here (in Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildTarget.cs):

	// Create modules for this plugin
	UEBuildBinaryType BinaryType = ShouldCompileMonolithic() ? UEBuildBinaryType.StaticLibrary : UEBuildBinaryType.DynamicLinkLibrary;
	if (Info.Descriptor.Modules != null)
	{
		foreach (ModuleDescriptor ModuleInfo in Info.Descriptor.Modules)
		{
			if (ModuleInfo.IsCompiledInConfiguration(Platform, TargetType, Rules.bBuildDeveloperTools, Rules.bBuildEditor, Rules.bBuildRequiresCookedData))
			{
				UEBuildModule Module = FindOrCreateModuleByName(ModuleInfo.Name, PluginReferenceChain);
// BEGIN PATCH
				if(!Instance.Modules.Contains(Module))
				{
// END PATCH
					if (!Module.RulesFile.IsUnderDirectory(Info.Directory))
					{
						throw new BuildException("Plugin '{0}' (referenced via {1}) does not contain the '{2}' module, but lists it in '{3}'.", Info.Name, ReferenceChain, ModuleInfo.Name, Info.File);
					}
					Instance.bDescriptorNeededAtRuntime = true;
					Instance.Modules.Add(Module);
// BEGIN PATCH
				}
// END PATCH
			}
		}
	}

[ryanjon2040]

Thank you so much for fixing our issues Ben! . I really appreciate the quick fixes .

[SlimeQ]

I'm still getting this error after installing the QFE, at least when editing project plugin code. I have to generate project files every time i compile.

[ryanjon2040]

[MENTION=1345]Ben Marsh[/MENTION]

Problem still persists after applying QFE

[Roi Danton]

EDIT: My apologies, this occurred due to changes in ustruct used in blueprints. Compilation works with VS2017.

The QFE didn't work for me either: VisualStudio.15.Release/15.2.0+26430.16 (VS2017 Community) still getting

UnrealHeaderTool failed for target 'TestProjectEditor' (platform: Win64, module info: TestProjectPath\Intermediate\Build\Win64\TestProjectEditor\Development\TestProjectEditor.uhtmanifest, exit code: OtherCompilationError (5)).

Fresh UE4.17 install, no plugins, C++ project.

[Ben Marsh]

[MENTION=1345]Ben Marsh[/MENTION]

Problem still persists after applying QFE

Are you seeing exactly the same error message?

If the callstack is the same, it sounds like there's something wrong with the QFE bundle itself - it should remove the possibility of getting that callstack entirely, and did fix the issue on my install. Can you check whether the timestamp on Engine/Binaries/DotNET/UnrealBuildTool.exe is updated after applying it?

[ryanjon2040]

[MENTION=1345]Ben Marsh[/MENTION] Ok the issue seems to be gone now. These are the things I did today morning and so far my project is compiling without any issues.

1: Closed all Unreal Editor instances.
2: Closed Visual Studio.
3: Redownloaded and applied QFE. It showed "Your Unreal Engine is now patched".
4: Regenerated my project files. (Right click on uproject file and select "Generate Visual Studio project files").
5: Start compiling

After doing all of the above steps, project seems to compile fine.

[Büke]

This bug is back in 4.18p1 and p2. Here are my comments cross posted:

Still no progress at 4.18p2. With the Editor and Hot Loading, UnrealHeaderTool runs extraneously on unchanged .h files again and again. What used to take 8 seconds to compile now takes 30! Close the editor, and it is back to normal behavior... change a .cpp file and only that file compiles in 8 seconds.
https://answers.unrealengine.com/que...ec-135sec.html

However there are new bugs... With the editor closed, changing an .h file triggers "System.ArgumentNullException: Value cannot be null." in UE_4.18\Engine\Build\BatchFiles\Build.bat. One way out of that is a clean rebuild of everything. This has been documented since 4.17: https://forums.unrealengine.com/deve...4-17-preview-3

Another insidious new bug in 4.18 is all the UPROPERTYs Disappearing at the Details panel after a Hotload! It is intermittent but very frequent. Only way out of that is adding or renaming a dummy UPROPERTY to trigger an update on the Details panel.

The state of support for C++ developers at Epic is quite sad. It seems, the developers are hardly testing any of this. It is as if, all the company cares about lately is blueprint spaghetti...

[ryanjon2040]

Yup I can confirm this. Project fails to compile second time in 4.18 P2.

1>------ Build started: Project: MyProject, Configuration: Development_Editor x64 ------
1>EXEC : error : System.ArgumentNullException: Value cannot be null.
1>       Parameter name: source
1>          at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
1>          at UnrealBuildTool.ExternalExecution.ExecuteHeaderToolIfNecessary(BuildConfiguration BuildConfiguration, UEBuildTarget Target, CppCompileEnvironment GlobalCompileEnvironment, List`1 UObjectModules, FileReference ModuleInfoFileName, ECompilationResult& UHTResult)
1>          at UnrealBuildTool.UnrealBuildTool.RunUBT(BuildConfiguration BuildConfiguration, String[] Arguments, FileReference ProjectFile)
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.MakeFile.Targets(44,5): error MSB3075: The command ""D:\Unreal Engines\UE_4.18\Engine\Build\BatchFiles\Build.bat" MyProjectEditor Win64 Development "E:\Unreal Projects\MyProject\MyProject.uproject" -waitmutex" exited with code 5. Please verify that you have sufficient rights to run this command.
1>Done building project "MyProject.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

[Ben Marsh]

I've re-applied the fix in CL 3677373. It's very unfortunate that we hit the same issue again, and that we didn't learn our lesson and arrange test coverage around it the first time. I've raised it as an issue, and we'll add test cases around it in the future.

[ryanjon2040]

I've re-applied the fix in CL 3677373. It's very unfortunate that we hit the same issue again, and that we didn't learn our lesson and arrange test coverage around it the first time. I've raised it as an issue, and we'll add test cases around it in the future.

No worries Ben . Is there a QFE available for 4.18?

[DJRD4465]

Seen again on 4.18 Preview 3. Every time I want to compile I have to generate project files again. Not ideal, obviously.

Is there a QFE coming for this Ben?

[ryanjon2040]

Issue seems to be fixed in 4.19. Compiled my project more than 10 times and it compiled without issues.